gora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewi...@apache.org
Subject svn commit: r1229178 - in /incubator/gora/trunk: CHANGES.txt gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java
Date Mon, 09 Jan 2012 14:44:25 GMT
Author: lewismc
Date: Mon Jan  9 14:44:25 2012
New Revision: 1229178

URL: http://svn.apache.org/viewvc?rev=1229178&view=rev
Log:
commit to address GORA-66 and update to CHANGES.txt. Thank you Keith for the patch

Modified:
    incubator/gora/trunk/CHANGES.txt
    incubator/gora/trunk/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java

Modified: incubator/gora/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/CHANGES.txt?rev=1229178&r1=1229177&r2=1229178&view=diff
==============================================================================
--- incubator/gora/trunk/CHANGES.txt (original)
+++ incubator/gora/trunk/CHANGES.txt Mon Jan  9 14:44:25 2012
@@ -2,6 +2,8 @@ Gora Change Log
 
 Trunk (unreleased changes):
 
+* GORA-66 testDeleteByQueryFields seems incorrect (Keith Turner via lewismc)
+
 * GORA-72 Made all artifacts proper OSGi bundles. Added ClassLoadingUtils which will fallback
to thread context classloader if Class.forName fails. (iocanel)
 
 * GORA-55 Removed second assertion for schema existence, since schema is already deleted,
Excluded ranged queries from the tests, since the tests assume end key to be inclussive while
Hbase considers it exclusive. (iocanel)

Modified: incubator/gora/trunk/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java?rev=1229178&r1=1229177&r2=1229178&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java
(original)
+++ incubator/gora/trunk/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java
Mon Jan  9 14:44:25 2012
@@ -650,6 +650,9 @@ public class DataStoreTestUtil {
     store.deleteByQuery(query);
     store.deleteByQuery(query);
     store.deleteByQuery(query);//don't you love that HBase sometimes does not delete arbitrarily
+    
+    store.flush();
+    
     assertNumResults(store.newQuery(), URLS.length);
 
     //assert that data is deleted
@@ -683,6 +686,8 @@ public class DataStoreTestUtil {
     store.deleteByQuery(query);
     store.deleteByQuery(query);
     store.deleteByQuery(query);//don't you love that HBase sometimes does not delete arbitrarily
+    
+    store.flush();
 
     assertNumResults(store.newQuery(), URLS.length);
 
@@ -690,7 +695,7 @@ public class DataStoreTestUtil {
     for (int i = 0; i < URLS.length; i++) {
       WebPage page = store.get(URLS[i]);
       Assert.assertNotNull(page);
-      if( URLS[i].compareTo(startKey) < 0 || URLS[i].compareTo(endKey) >= 0) {
+      if( URLS[i].compareTo(startKey) < 0 || URLS[i].compareTo(endKey) > 0) {
         //not deleted
         assertWebPage(page, i);
       } else {



Mime
View raw message