gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (GOBBLIN-880) Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + enable TTL + dnsSrv
Date Fri, 13 Sep 2019 21:48:00 GMT

     [ https://issues.apache.org/jira/browse/GOBBLIN-880?focusedWorklogId=312362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312362
]

ASF GitHub Bot logged work on GOBBLIN-880:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/19 21:47
            Start Date: 13/Sep/19 21:47
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2734: GOBBLIN-880 Bump CouchbaseWriter
Couchbase SDK version + write docs +…
URL: https://github.com/apache/incubator-gobblin/pull/2734#issuecomment-531401555
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2734?src=pr&el=h1)
Report
   > Merging [#2734](https://codecov.io/gh/apache/incubator-gobblin/pull/2734?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/c35871920cc5f8378a4f9962658b840994f071f5?src=pr&el=desc)
will **increase** coverage by `0.03%`.
   > The diff coverage is `59.4%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2734?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2734      +/-   ##
   ============================================
   + Coverage     45.04%   45.07%   +0.03%     
   - Complexity     8751     8761      +10     
   ============================================
     Files          1884     1884              
     Lines         70311    70379      +68     
     Branches       7716     7723       +7     
   ============================================
   + Hits          31672    31726      +54     
   - Misses        35697    35708      +11     
   - Partials       2942     2945       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2734?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...bblin/couchbase/writer/CouchbaseWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlV3JpdGVyQnVpbGRlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../couchbase/writer/CouchbaseEnvironmentFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlRW52aXJvbm1lbnRGYWN0b3J5LmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...hbase/writer/CouchbaseWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlV3JpdGVyQ29uZmlndXJhdGlvbktleXMuamF2YQ==)
| `95.65% <100%> (+1.9%)` | `2 <0> (ø)` | :arrow_down: |
   | [...main/java/org/apache/gobblin/util/ConfigUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQ29uZmlnVXRpbHMuamF2YQ==)
| `60.4% <100%> (+2.54%)` | `40 <3> (+3)` | :arrow_up: |
   | [...ache/gobblin/couchbase/writer/CouchbaseWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlV3JpdGVyLmphdmE=)
| `64.39% <61.97%> (-4.22%)` | `15 <4> (+4)` | |
   | [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
   | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `65.72% <0%> (+1.4%)` | `28% <0%> (ø)` | :arrow_down: |
   | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
   | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2734/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `39.25% <0%> (+6.54%)` | `13% <0%> (+2%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2734?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2734?src=pr&el=footer).
Last update [c358719...06bc2f8](https://codecov.io/gh/apache/incubator-gobblin/pull/2734?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 312362)
    Remaining Estimate: 167h 40m  (was: 167h 50m)
            Time Spent: 20m  (was: 10m)

> Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + enable TTL
+ dnsSrv
> -----------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-880
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-880
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-couchbase
>            Reporter: Michael A Menarguez
>            Assignee: Shirshanka Das
>            Priority: Major
>              Labels: Couchbase
>   Original Estimate: 168h
>          Time Spent: 20m
>  Remaining Estimate: 167h 40m
>
> h1. h1. CURRENT ISSUES
> Currently CouchbaseWriter.java lacks the ability to do the following:
>  # Use certificate based authentication
>  # Set document expiry (TTL)
>  ** based on write time
>  ** based on an offset specified field contained in the record's data (JSON)
>  ** (WILL NOT ADRESS) set expiry based on a field contained in the record's data
>  # Set DNS SRV for bootstrap host discovery setting
>  # Missing documentation on CouchbaseWriter usage
>  # Testing does not bring in CouchbaseMock correctly and causes problems while bumping com.couchbase.client:java-client
> h1. h1. PROPOSED SOLUTIONS
>  # Add logic to connect using certificate based auth to the buckets (Will need to bump  com.couchbase.client:java-client
to a newer version like 2.7.6) and associated configs
>  # TTL implementation
>  ## Add configs to allow setting a TTL (documentTTL) and also specify the timeunits
(documentTTLUnits) of these settings
>  ## Add logic to specify the path to key to the field containing the source timestamp
(documentTTLOriginField) and its units (documentTTLOriginUnits) to disambiguate between UNIX
(sec) timestamps and other formats like timestamps in milliseconds.
>  ## N/A but logic would be similar to (2)
>  # Add missing dnsSrv config
>  # Write proper documentation
>  # Bring in CouchbaseMock from Gradle and adapt existing unit tests.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message