gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-gobblin] codecov-io commented on issue #2733: Modify GaaS configuration so that it runs through the startup script
Date Thu, 12 Sep 2019 22:37:23 GMT
codecov-io commented on issue #2733: Modify GaaS configuration so that it runs through the
startup script
URL: https://github.com/apache/incubator-gobblin/pull/2733#issuecomment-531033131
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2733?src=pr&el=h1)
Report
   > Merging [#2733](https://codecov.io/gh/apache/incubator-gobblin/pull/2733?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/c35871920cc5f8378a4f9962658b840994f071f5?src=pr&el=desc)
will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2733/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2733?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2733      +/-   ##
   ============================================
   + Coverage     45.04%   45.06%   +0.01%     
   - Complexity     8751     8753       +2     
   ============================================
     Files          1884     1884              
     Lines         70311    70311              
     Branches       7716     7716              
   ============================================
   + Hits          31672    31683      +11     
   + Misses        35697    35685      -12     
   - Partials       2942     2943       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2733?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2733/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | |
   | [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2733/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.87% <0%> (+0.67%)` | `25% <0%> (+1%)` | :arrow_up: |
   | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2733/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
   | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2733/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
   | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2733/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `39.25% <0%> (+6.54%)` | `13% <0%> (+2%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2733?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2733?src=pr&el=footer).
Last update [c358719...fe6b75a](https://codecov.io/gh/apache/incubator-gobblin/pull/2733?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message