From dev-return-4363-archive-asf-public=cust-asf.ponee.io@gobblin.incubator.apache.org Tue Jun 4 18:49:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 095C818064D for ; Tue, 4 Jun 2019 20:48:59 +0200 (CEST) Received: (qmail 87956 invoked by uid 500); 4 Jun 2019 18:48:59 -0000 Mailing-List: contact dev-help@gobblin.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gobblin.incubator.apache.org Delivered-To: mailing list dev@gobblin.incubator.apache.org Received: (qmail 87945 invoked by uid 99); 4 Jun 2019 18:48:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2019 18:48:59 +0000 From: GitBox To: dev@gobblin.apache.org Subject: [GitHub] [incubator-gobblin] sv2000 opened a new pull request #2662: GOBBLIN-795: Make JobCatalog optional for FsJobConfigurationManager Message-ID: <155967413427.13130.17770684413444036192.gitbox@gitbox.apache.org> Date: Tue, 04 Jun 2019 18:48:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sv2000 opened a new pull request #2662: GOBBLIN-795: Make JobCatalog optional for FsJobConfigurationManager URL: https://github.com/apache/incubator-gobblin/pull/2662 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-795 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): Existing behavior enforces the need to provide a JobCatalog. We relax this requirement and allow the JobConfigurationManager to bootstrap the gobblin cluster with job configs from a configured location (as opposed to bootstrapping from a JobCatalog). ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Unit tests in JobConfigurationManagerTest ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services