gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (GOBBLIN-796) Add option to trigger a flow
Date Thu, 06 Jun 2019 20:24:00 GMT

     [ https://issues.apache.org/jira/browse/GOBBLIN-796?focusedWorklogId=255402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255402
]

ASF GitHub Bot logged work on GOBBLIN-796:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jun/19 20:23
            Start Date: 06/Jun/19 20:23
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2663: [GOBBLIN-796] Add option to
trigger a flow
URL: https://github.com/apache/incubator-gobblin/pull/2663#discussion_r291004380
 
 

 ##########
 File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java
 ##########
 @@ -171,6 +171,15 @@ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig,
boo
       FlowConfig originalFlowConfig = getFlowConfig(flowId);
       originalFlowConfig.setSchedule(NEVER_RUN_CRON_SCHEDULE);
       flowConfig = originalFlowConfig;
+    } else if (isTriggerRequest(flowConfig)) {
 
 Review comment:
   We do not need special handling to detect a "trigger" request, if we treat all Update FlowConfig
operations as partial updates i.e. merge the old FlowConfig with the config provided in the
update request.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 255402)
    Time Spent: 50m  (was: 40m)

> Add option to trigger a flow
> ----------------------------
>
>                 Key: GOBBLIN-796
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-796
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message