gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (GOBBLIN-754) Craftsmanship cleaning on redundancy of different versions of FlowCompiler
Date Mon, 03 Jun 2019 20:04:00 GMT

     [ https://issues.apache.org/jira/browse/GOBBLIN-754?focusedWorklogId=253317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253317
]

ASF GitHub Bot logged work on GOBBLIN-754:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jun/19 20:03
            Start Date: 03/Jun/19 20:03
    Worklog Time Spent: 10m 
      Work Description: autumnust commented on pull request #2660: [GOBBLIN-754] Clean old
version of multi-hop compiler
URL: https://github.com/apache/incubator-gobblin/pull/2660
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off
all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/)
issues and references them in the PR title. 
       - https://issues.apache.org/jira/browse/GOBBLIN-754
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   Cleaning the old version of FlowCompiler to avoid confusion. 
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 253317)
            Time Spent: 10m
    Remaining Estimate: 0h

> Craftsmanship cleaning on redundancy of different versions of FlowCompiler 
> ---------------------------------------------------------------------------
>
>                 Key: GOBBLIN-754
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-754
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are a lot of redundant interfaces/implementation of FlowCompiler existed in codebase.
Should do a cleaning to avoid confusion. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message