gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2647: [GOBBLIN-781] Skeleton for GaaS DR mode clean transition
Date Thu, 06 Jun 2019 05:36:34 GMT
autumnust commented on a change in pull request #2647: [GOBBLIN-781] Skeleton for GaaS DR mode
clean transition
URL: https://github.com/apache/incubator-gobblin/pull/2647#discussion_r291025837
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
 ##########
 @@ -170,6 +195,19 @@ private void scheduleSpecsFromCatalog() {
     }
   }
 
+  /**
+   * In DR-mode, the running {@link FlowSpec} will all be cancelled and rescheduled.
+   * We will need to make sure that running {@link FlowSpec}s' state are cleared, and corresponding
running jobs are
+   * killed before rescheduling them.
+   * @param drUris The uris that applicable for DR discovered from FlowCatalog.
+   */
+  private void clearRunningFlowState(Iterator<URI> drUris) {
 
 Review comment:
   Actually the structure is pretty isolated since all additional thing added is calling this
method. It shouldn't be very hard to migrate to a RESTful design. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message