gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-gobblin] sv2000 opened a new pull request #2662: GOBBLIN-795: Make JobCatalog optional for FsJobConfigurationManager
Date Tue, 04 Jun 2019 18:48:54 GMT
sv2000 opened a new pull request #2662: GOBBLIN-795: Make JobCatalog optional for FsJobConfigurationManager
URL: https://github.com/apache/incubator-gobblin/pull/2662
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off
all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/)
issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-795
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   Existing behavior enforces the need to provide a JobCatalog. We relax this requirement
and allow the JobConfigurationManager to bootstrap the gobblin cluster with job configs from
a configured location (as opposed to bootstrapping from a JobCatalog). 
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   Unit tests in JobConfigurationManagerTest
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message