gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-gobblin] chris9692 opened a new pull request #2661: [GOBBLIN-794] JsonIntermediateToAvroConverter cannot process array-object-array-object nested pattern
Date Tue, 04 Jun 2019 16:47:22 GMT
chris9692 opened a new pull request #2661: [GOBBLIN-794] JsonIntermediateToAvroConverter cannot
process array-object-array-object nested pattern
URL: https://github.com/apache/incubator-gobblin/pull/2661
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I have a use case pending this fix.
   
   ### JIRA
   - [ ] My PR addresses the following:
       - https://issues.apache.org/jira/browse/GOBBLIN-794
   
   ### Description
   - [ ] changes are adding namespace parameter to ArrayConverter of the JsonIntermediateToAvroConverter,
and there is a test case to verify.
   
   ### Tests
   - [ ] My PR adds the following unit tests:   testConverterWithNestJson
   - [ ] Unit test results:
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest.
STARTED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest.
PASSED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest.
STARTED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest.
PASSED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest.
STARTED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest.
PASSED
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message