gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2658: [GOBBLIN-793] Separate SpecSerDe from SpecCatalogs and add GsonSpecSerDe
Date Mon, 03 Jun 2019 18:29:13 GMT
autumnust commented on a change in pull request #2658: [GOBBLIN-793] Separate SpecSerDe from
SpecCatalogs and add GsonSpecSerDe
URL: https://github.com/apache/incubator-gobblin/pull/2658#discussion_r289975609

 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_serde/GsonSpecSerDe.java
 @@ -0,0 +1,61 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.spec_serde;
+import com.google.gson.Gson;
+import com.google.gson.JsonParseException;
+import com.google.gson.reflect.TypeToken;
+import org.apache.gobblin.runtime.api.FlowSpec;
+import org.apache.gobblin.runtime.api.Spec;
+import org.apache.gobblin.runtime.api.SpecSerDe;
+import org.apache.gobblin.runtime.api.SpecSerDeException;
+ * {@link SpecSerDe} that serializes as Json using {@link Gson}. Note that currently only
{@link FlowSpec}s are supported.
+ */
+public class GsonSpecSerDe implements SpecSerDe {
 Review comment:
   I don't think we could make it work for different implementations of `Spec` so shall we
just name it as `GsonFlowSpecSerDe` ? 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message