gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (GOBBLIN-768) Add MySQL implementation of SpecStore
Date Tue, 14 May 2019 06:22:00 GMT

     [ https://issues.apache.org/jira/browse/GOBBLIN-768?focusedWorklogId=241547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241547
]

ASF GitHub Bot logged work on GOBBLIN-768:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/May/19 06:21
            Start Date: 14/May/19 06:21
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2631: [GOBBLIN-768] Add MySQL implementation
of SpecStore
URL: https://github.com/apache/incubator-gobblin/pull/2631#discussion_r283640064
 
 

 ##########
 File path: gobblin-runtime/src/test/java/org/apache/gobblin/runtime/spec_store/MysqlSpecStoreTest.java
 ##########
 @@ -66,16 +68,23 @@ public void setUp() throws Exception {
         .addPrimitive(ConfigurationKeys.STATE_STORE_DB_TABLE_KEY, TABLE)
         .build();
 
-    this.specStore = new MysqlSpecStore(config);
+    this.specStore = new MysqlSpecStore(config, new TestSpecSerDe());
   }
 
   @Test
-  public void testAddGetSpec() throws Exception {
+  public void testAddSpec() throws Exception {
     this.specStore.addSpec(this.flowSpec1);
     this.specStore.addSpec(this.flowSpec2);
 
     Assert.assertTrue(this.specStore.exists(this.uri1));
+    Assert.assertTrue(this.specStore.exists(this.uri2));
     Assert.assertFalse(this.specStore.exists(URI.create("dummy")));
+  }
+
+  @Test
+  public void testGetSpec() throws Exception {
 
 Review comment:
   Can we add a test for getSpecs() where the de-serialization of a spec fails, but getSpecs()
returns other valid specs?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 241547)
    Time Spent: 3h  (was: 2h 50m)

> Add MySQL implementation of SpecStore
> -------------------------------------
>
>                 Key: GOBBLIN-768
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-768
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message