gobblin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (GOBBLIN-760) Improve retrying behavior of throttling clients
Date Wed, 01 May 2019 06:22:00 GMT

     [ https://issues.apache.org/jira/browse/GOBBLIN-760?focusedWorklogId=235701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235701
]

ASF GitHub Bot logged work on GOBBLIN-760:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/May/19 06:21
            Start Date: 01/May/19 06:21
    Worklog Time Spent: 10m 
      Work Description: autumnust commented on pull request #2624: [GOBBLIN-760] Improve retrying
behavior of throttling client, add more informative …
URL: https://github.com/apache/incubator-gobblin/pull/2624#discussion_r280011104
 
 

 ##########
 File path: gobblin-restli/gobblin-throttling-service/gobblin-throttling-service-client/src/main/java/org/apache/gobblin/util/limiter/BatchedPermitsRequester.java
 ##########
 @@ -364,10 +393,22 @@ public void onSuccess(Response<PermitAllocation> result) {
       }
     }
 
+    public long elapsedTime() {
+      return System.currentTimeMillis() - this.startTime;
+    }
+
+    public synchronized void clearCallback() {
 
 Review comment:
   Why this method is needed if there's only one on-the-fly request ( corresponding one callback)
being existed ? Can't it be simply `clearSemaphore` instead of having a `callbackcleared`
method for protection? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 235701)
    Time Spent: 40m  (was: 0.5h)

> Improve retrying behavior of throttling clients
> -----------------------------------------------
>
>                 Key: GOBBLIN-760
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-760
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Issac Buenrostro
>            Assignee: Issac Buenrostro
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message