Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 97D5E200CD6 for ; Mon, 31 Jul 2017 09:52:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 966231649FC; Mon, 31 Jul 2017 07:52:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A95DD1649CA for ; Mon, 31 Jul 2017 09:52:36 +0200 (CEST) Received: (qmail 19555 invoked by uid 500); 31 Jul 2017 07:52:35 -0000 Mailing-List: contact commits-help@gobblin.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gobblin.incubator.apache.org Delivered-To: mailing list commits@gobblin.incubator.apache.org Received: (qmail 16877 invoked by uid 99); 31 Jul 2017 07:52:24 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Jul 2017 07:52:24 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5C4FCF3371; Mon, 31 Jul 2017 07:52:21 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: abti@apache.org To: commits@gobblin.apache.org Date: Mon, 31 Jul 2017 07:53:32 -0000 Message-Id: <3eb23b8b52da4f75a4a309abf951c8c1@git.apache.org> In-Reply-To: <50c2ce484ba041a294296078b24418ae@git.apache.org> References: <50c2ce484ba041a294296078b24418ae@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [74/77] [abbrv] incubator-gobblin git commit: Disable backward compatibility test for FSStateStore since we are doing major version change archived-at: Mon, 31 Jul 2017 07:52:37 -0000 Disable backward compatibility test for FSStateStore since we are doing major version change Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/399d1d12 Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/399d1d12 Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/399d1d12 Branch: refs/heads/master Commit: 399d1d12000daadb3409720fa0e153e0c3f1865b Parents: 1737fde Author: Abhishek Tiwari Authored: Sun Jul 30 22:46:54 2017 -0700 Committer: Abhishek Tiwari Committed: Sun Jul 30 22:46:54 2017 -0700 ---------------------------------------------------------------------- .../gobblin/metastore/FsStateStoreTest.java | 42 ++++++++++---------- 1 file changed, 22 insertions(+), 20 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/399d1d12/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java ---------------------------------------------------------------------- diff --git a/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java b/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java index 052f1d2..11154c1 100644 --- a/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java +++ b/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java @@ -117,26 +117,28 @@ public class FsStateStoreTest { Assert.assertEquals(states.get(2).getProp("k3"), "v3"); } - @Test - public void testBackwardsCompat() throws IOException { - // Tests with a state store that was saved before the WritableShim changes - Config bwConfig = ConfigFactory.load(config); - URL path = getClass().getResource("/backwardsCompatTestStore"); - Assert.assertNotNull(path); - - bwConfig = bwConfig.withValue(ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY, - ConfigValueFactory.fromAnyRef(path.toString())); - - StateStore bwStateStore = stateStoreFactory.createStateStore(bwConfig, State.class); - Assert.assertTrue(bwStateStore.exists("testStore", "testTable")); - - List states = bwStateStore.getAll("testStore", "testTable"); - Assert.assertEquals(states.size(), 3); - - Assert.assertEquals(states.get(0).getProp("k1"), "v1"); - Assert.assertEquals(states.get(1).getProp("k2"), "v2"); - Assert.assertEquals(states.get(2).getProp("k3"), "v3"); - } +// Disable backwards compatibility change, since we are doing a major version upgrade +// .. and this is related to previous migration. +// @Test +// public void testBackwardsCompat() throws IOException { +// // Tests with a state store that was saved before the WritableShim changes +// Config bwConfig = ConfigFactory.load(config); +// URL path = getClass().getResource("/backwardsCompatTestStore"); +// Assert.assertNotNull(path); +// +// bwConfig = bwConfig.withValue(ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY, +// ConfigValueFactory.fromAnyRef(path.toString())); +// +// StateStore bwStateStore = stateStoreFactory.createStateStore(bwConfig, State.class); +// Assert.assertTrue(bwStateStore.exists("testStore", "testTable")); +// +// List states = bwStateStore.getAll("testStore", "testTable"); +// Assert.assertEquals(states.size(), 3); +// +// Assert.assertEquals(states.get(0).getProp("k1"), "v1"); +// Assert.assertEquals(states.get(1).getProp("k2"), "v2"); +// Assert.assertEquals(states.get(2).getProp("k3"), "v3"); +// } @AfterClass public void tearDown() throws IOException {