gobblin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [74/77] [abbrv] incubator-gobblin git commit: Disable backward compatibility test for FSStateStore since we are doing major version change
Date Mon, 31 Jul 2017 07:53:32 GMT
Disable backward compatibility test for FSStateStore since we are doing major version change


Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/399d1d12
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/399d1d12
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/399d1d12

Branch: refs/heads/master
Commit: 399d1d12000daadb3409720fa0e153e0c3f1865b
Parents: 1737fde
Author: Abhishek Tiwari <abhishektiwari.btech@gmail.com>
Authored: Sun Jul 30 22:46:54 2017 -0700
Committer: Abhishek Tiwari <abhishektiwari.btech@gmail.com>
Committed: Sun Jul 30 22:46:54 2017 -0700

----------------------------------------------------------------------
 .../gobblin/metastore/FsStateStoreTest.java     | 42 ++++++++++----------
 1 file changed, 22 insertions(+), 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/399d1d12/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java
----------------------------------------------------------------------
diff --git a/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java
b/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java
index 052f1d2..11154c1 100644
--- a/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java
+++ b/gobblin-metastore/src/test/java/org/apache/gobblin/metastore/FsStateStoreTest.java
@@ -117,26 +117,28 @@ public class FsStateStoreTest {
     Assert.assertEquals(states.get(2).getProp("k3"), "v3");
   }
 
-  @Test
-  public void testBackwardsCompat() throws IOException {
-    // Tests with a state store that was saved before the WritableShim changes
-    Config bwConfig = ConfigFactory.load(config);
-    URL path = getClass().getResource("/backwardsCompatTestStore");
-    Assert.assertNotNull(path);
-
-    bwConfig = bwConfig.withValue(ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY,
-        ConfigValueFactory.fromAnyRef(path.toString()));
-
-    StateStore<State> bwStateStore = stateStoreFactory.createStateStore(bwConfig, State.class);
-    Assert.assertTrue(bwStateStore.exists("testStore", "testTable"));
-
-    List<State> states = bwStateStore.getAll("testStore", "testTable");
-    Assert.assertEquals(states.size(), 3);
-
-    Assert.assertEquals(states.get(0).getProp("k1"), "v1");
-    Assert.assertEquals(states.get(1).getProp("k2"), "v2");
-    Assert.assertEquals(states.get(2).getProp("k3"), "v3");
-  }
+//  Disable backwards compatibility change, since we are doing a major version upgrade
+//  .. and this is related to previous migration.
+//  @Test
+//  public void testBackwardsCompat() throws IOException {
+//    // Tests with a state store that was saved before the WritableShim changes
+//    Config bwConfig = ConfigFactory.load(config);
+//    URL path = getClass().getResource("/backwardsCompatTestStore");
+//    Assert.assertNotNull(path);
+//
+//    bwConfig = bwConfig.withValue(ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY,
+//        ConfigValueFactory.fromAnyRef(path.toString()));
+//
+//    StateStore<State> bwStateStore = stateStoreFactory.createStateStore(bwConfig,
State.class);
+//    Assert.assertTrue(bwStateStore.exists("testStore", "testTable"));
+//
+//    List<State> states = bwStateStore.getAll("testStore", "testTable");
+//    Assert.assertEquals(states.size(), 3);
+//
+//    Assert.assertEquals(states.get(0).getProp("k1"), "v1");
+//    Assert.assertEquals(states.get(1).getProp("k2"), "v2");
+//    Assert.assertEquals(states.get(2).getProp("k3"), "v3");
+//  }
 
   @AfterClass
   public void tearDown() throws IOException {


Mime
View raw message