Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F0E2416787E for ; Tue, 22 Aug 2017 22:57:09 +0200 (CEST) Received: (qmail 29158 invoked by uid 500); 22 Aug 2017 20:57:04 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 29147 invoked by uid 500); 22 Aug 2017 20:57:04 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 29144 invoked by uid 99); 22 Aug 2017 20:57:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 20:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C8AD7C006E for ; Tue, 22 Aug 2017 20:57:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ej7ThGMGbwHv for ; Tue, 22 Aug 2017 20:57:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6B0C661A58 for ; Tue, 22 Aug 2017 20:57:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 77438E08C6 for ; Tue, 22 Aug 2017 20:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 69BAB2538E for ; Tue, 22 Aug 2017 20:57:00 +0000 (UTC) Date: Tue, 22 Aug 2017 20:57:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GIRAPH-1151) Avoid message value factory initialization in Apache Giraph MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137400#comment-16137400 ] ASF GitHub Bot commented on GIRAPH-1151: ---------------------------------------- Github user yukselakinci closed the pull request at: https://github.com/apache/giraph/pull/42 > Avoid message value factory initialization in Apache Giraph > ----------------------------------------------------------- > > Key: GIRAPH-1151 > URL: https://issues.apache.org/jira/browse/GIRAPH-1151 > Project: Giraph > Issue Type: Improvement > Reporter: Yuksel Akinci > Original Estimate: 168h > Remaining Estimate: 168h > > Messages in Giraph are instantiated using a "message value factory" class. Currently the message value factory gets instantiated every time a message is sent, which is unnecessary and can cause high overhead if the message value factory constructor contains expensive operation. Factory objects are be saved to avoid repeated expensive object creations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)