giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1151) Avoid message value factory initialization in Apache Giraph
Date Thu, 17 Aug 2017 07:32:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130051#comment-16130051
] 

ASF GitHub Bot commented on GIRAPH-1151:
----------------------------------------

GitHub user yukselakinci opened a pull request:

    https://github.com/apache/giraph/pull/42

    Avoid message value factory initialization in Apache Giraph

    Jira ticket id: https://issues.apache.org/jira/browse/GIRAPH-1151

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yukselakinci/giraph avoidfactoryinit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/giraph/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit 1216cde8326753c5a6fafa315cab2d59c7c7d7d0
Author: Yuksel Akinci <yuksela@fb.com>
Date:   2017-08-16T23:31:51Z

    Avoid message value factory initialization in Apache Giraph
    Jira ticket id: https://issues.apache.org/jira/browse/GIRAPH-1151

----


> Avoid message value factory initialization in Apache Giraph
> -----------------------------------------------------------
>
>                 Key: GIRAPH-1151
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1151
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Yuksel Akinci
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Messages in Giraph are instantiated using a "message value factory" class. Currently
the message value factory gets instantiated every time a message is sent, which is unnecessary
and can cause high overhead if the message value factory constructor contains expensive operation.
Factory objects are  be saved to avoid repeated expensive object creations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message