giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1138) Don't wrap exceptions from executor service
Date Thu, 04 May 2017 20:18:04 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997373#comment-15997373
] 

ASF GitHub Bot commented on GIRAPH-1138:
----------------------------------------

GitHub user majakabiljo opened a pull request:

    https://github.com/apache/giraph/pull/37

    [GIRAPH-1138] Don't wrap exceptions from executor service

    Summary: In ProgressableUtils.getResultsWithNCallables we wrap exceptions from underlying
threads, making logs hard to read. We should re-throw original exception when possible. (accidentally
closed #27)
    
    Test Plan: Ran a job which fails in one of input threads before and after change, verified
exception is clear now

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/majakabiljo/giraph exceptions2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/giraph/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit c859833de5a28e580b38dc46a8b371cd82b6b6d0
Author: Maja Kabiljo <majakabiljo@fb.com>
Date:   2017-05-04T20:15:44Z

    [GIRAPH-1138] Don't wrap exceptions from executor service
    
    Summary: In ProgressableUtils.getResultsWithNCallables we wrap exceptions from underlying
threads, making logs hard to read. We should re-throw original exception when possible. (accidentally
closed #27)
    
    Test Plan: Ran a job which fails in one of input threads before and after change, verified
exception is clear now

----


> Don't wrap exceptions from executor service
> -------------------------------------------
>
>                 Key: GIRAPH-1138
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1138
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>            Priority: Minor
>
> In ProgressableUtils.getResultsWithNCallables we wrap exceptions from underlying threads,
making logs hard to read. We should re-throw original exception when possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message