Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1C505200B36 for ; Tue, 21 Jun 2016 19:29:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1AEC0160A4F; Tue, 21 Jun 2016 17:29:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 64212160A60 for ; Tue, 21 Jun 2016 19:28:59 +0200 (CEST) Received: (qmail 40198 invoked by uid 500); 21 Jun 2016 17:28:58 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 40017 invoked by uid 500); 21 Jun 2016 17:28:58 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 40014 invoked by uid 99); 21 Jun 2016 17:28:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2016 17:28:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 373EB2C1F6B for ; Tue, 21 Jun 2016 17:28:58 +0000 (UTC) Date: Tue, 21 Jun 2016 17:28:58 +0000 (UTC) From: "Hudson (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GIRAPH-1076) Race condition in FileTxnSnapLog MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Jun 2016 17:29:00 -0000 [ https://issues.apache.org/jira/browse/GIRAPH-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342252#comment-15342252 ] Hudson commented on GIRAPH-1076: -------------------------------- FAILURE: Integrated in Giraph-trunk-Commit #1625 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1625/]) GIRAPH-1076 Race condition in FileTxnSnapLog (edunov: [http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=2185f5946edfddcca8a5bcb76160212bfe2ef797]) * giraph-core/src/main/java/org/apache/giraph/zk/InProcessZooKeeperRunner.java > Race condition in FileTxnSnapLog > -------------------------------- > > Key: GIRAPH-1076 > URL: https://issues.apache.org/jira/browse/GIRAPH-1076 > Project: Giraph > Issue Type: Bug > Reporter: Sergey Edunov > Assignee: Sergey Edunov > > org.apache.zookeeper.server.persistence.FileTxnSnapLog has a potential for race condition: > if (!this.dataDir.exists()) { > if (!this.dataDir.mkdirs()) { > throw new IOException("Unable to create data directory " > + this.dataDir); > } > } > If two threads try to create FileTxnSnapLog simultaneously it can trigger IOException. > We saw this happening in Giraph where FileTxnSnapLog is being created by PurgeTask created by DatadirCleanupManager and by InProcessZooKeeperRunner#runFromConfig -- This message was sent by Atlassian JIRA (v6.3.4#6332)