giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1076) Race condition in FileTxnSnapLog
Date Tue, 21 Jun 2016 17:28:58 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342252#comment-15342252
] 

Hudson commented on GIRAPH-1076:
--------------------------------

FAILURE: Integrated in Giraph-trunk-Commit #1625 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1625/])
GIRAPH-1076 Race condition in FileTxnSnapLog (edunov: [http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=2185f5946edfddcca8a5bcb76160212bfe2ef797])
* giraph-core/src/main/java/org/apache/giraph/zk/InProcessZooKeeperRunner.java


> Race condition in FileTxnSnapLog
> --------------------------------
>
>                 Key: GIRAPH-1076
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1076
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Sergey Edunov
>            Assignee: Sergey Edunov
>
> org.apache.zookeeper.server.persistence.FileTxnSnapLog has a potential for race condition:
>         if (!this.dataDir.exists()) {
>             if (!this.dataDir.mkdirs()) {
>                 throw new IOException("Unable to create data directory "
>                         + this.dataDir);
>             }
>         }
> If two threads try to create FileTxnSnapLog simultaneously it can trigger IOException.

> We saw this happening in Giraph where FileTxnSnapLog is being created by PurgeTask created
by DatadirCleanupManager and by InProcessZooKeeperRunner#runFromConfig 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message