Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D7E621797B for ; Thu, 5 Mar 2015 03:12:38 +0000 (UTC) Received: (qmail 8520 invoked by uid 500); 5 Mar 2015 03:12:38 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 8470 invoked by uid 500); 5 Mar 2015 03:12:38 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 8443 invoked by uid 500); 5 Mar 2015 03:12:38 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 8440 invoked by uid 99); 5 Mar 2015 03:12:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 03:12:38 +0000 Date: Thu, 5 Mar 2015 03:12:38 +0000 (UTC) From: "Dionysios Logothetis (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GIRAPH-997) Upgrade findbugs to 3.0.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348051#comment-14348051 ] Dionysios Logothetis commented on GIRAPH-997: --------------------------------------------- In practice I've never seen the return value being used. It would make more sense if registrations could collide across applications, or if registration contacted some external service. > Upgrade findbugs to 3.0.0 > ------------------------- > > Key: GIRAPH-997 > URL: https://issues.apache.org/jira/browse/GIRAPH-997 > Project: Giraph > Issue Type: Task > Reporter: Dionysios Logothetis > Assignee: Dionysios Logothetis > Priority: Minor > Labels: maven > Attachments: GIRAPH-997.patch > > > Finbugs 3.0.0 is necessary to build with Java 8, but it catches the following bugs on mvn -DskipTests -Dcheckstyle.skip=true clean install: > [INFO] --- findbugs-maven-plugin:3.0.0:check (default) @ giraph-core --- > [INFO] BugInstance size is 8 > [INFO] Error size is 0 > [INFO] Total bugs: 8 > [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.IntIntTextVertexValueInputFormat$IntIntTextVertexValueReader.preprocessLine(Text) ["org.apache.giraph.io.formats.IntIntTextVertexValueInputFormat$IntIntTextVertexValueReader"] At IntIntTextVertexValueInputFormat.java:[lines 54-71] > [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.IntNullTextEdgeInputFormat$IntNullTextEdgeReader.preprocessLine(Text) ["org.apache.giraph.io.formats.IntNullTextEdgeInputFormat$IntNullTextEdgeReader"] At IntNullTextEdgeInputFormat.java:[lines 53-76] > [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader.decodeEdge(String, String) ["org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader"] At LongDoubleDoubleAdjacencyListVertexInputFormat.java:[lines 49-75] > [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader.decodeId(String) ["org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader"] At LongDoubleDoubleAdjacencyListVertexInputFormat.java:[lines 49-75] > [INFO] Redundant nullcheck of org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class, boolean), which is known to be non-null in org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class) ["org.apache.giraph.master.AggregatorToGlobalCommTranslation"] At AggregatorToGlobalCommTranslation.java:[lines 40-220] > [INFO] Redundant nullcheck of org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class, boolean), which is known to be non-null in org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerPersistentAggregator(String, Class) ["org.apache.giraph.master.AggregatorToGlobalCommTranslation"] At AggregatorToGlobalCommTranslation.java:[lines 40-220] > [INFO] org.apache.giraph.zk.ZooKeeperManager.createZooKeeperServerList() invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead ["org.apache.giraph.zk.ZooKeeperManager"] At ZooKeeperManager.java:[lines 60-840] > [INFO] Inconsistent synchronization of org.apache.giraph.zk.ZooKeeperManager.zkRunner; locked 66% of time ["org.apache.giraph.zk.ZooKeeperManager"] At ZooKeeperManager.java:[lines 60-840] -- This message was sent by Atlassian JIRA (v6.3.4#6332)