giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Igor Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-938) Allow fast working with primitives generically
Date Thu, 07 Aug 2014 02:55:13 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088737#comment-14088737
] 

Igor Kabiljo commented on GIRAPH-938:
-------------------------------------

https://reviews.facebook.net/D21261

> Allow fast working with primitives generically
> ----------------------------------------------
>
>                 Key: GIRAPH-938
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-938
>             Project: Giraph
>          Issue Type: Improvement
>          Components: lib
>            Reporter: Igor Kabiljo
>
> Currently, there are generic classes that handle any types, but are slow and take a lot
of memory. So there are a lot of primitive specific classes, that just copy the same code,
with different types.
> That means both huge code duplication (which makes it easy to have bugs, and have versions
out of sync), and there are always usecases with types that are not covered - and so fallback
to very inefficient version.
> It is extremely expensive to use wrapped classes for making things work generically -
Integer, Long, etc.
> But using IntWritable, LongWritable, etc isn't, because they are mutable, and we can
have one reused object, which can be used as data transfer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message