giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Edunov" <edu...@gmail.com>
Subject Re: Review Request 24665: Review patch for the new SCC algorithm - GIRAPH-931
Date Fri, 15 Aug 2014 17:43:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24665/#review50748
-----------------------------------------------------------

Ship it!


Looks good to me! Maja, Pavan, can you please take a look & push it?

- Sergey Edunov


On Aug. 15, 2014, 8:31 a.m., Gianluca Righetto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24665/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 8:31 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> Review the second version of the patch for the issue GIRAPH-931 (Provide a Strongly Connected
Components algorithm).
> 
> 
> Diffs
> -----
> 
>   giraph-examples/pom.xml 90f6889 
>   giraph-examples/src/main/java/org/apache/giraph/examples/scc/SccComputation.java PRE-CREATION

>   giraph-examples/src/main/java/org/apache/giraph/examples/scc/SccLongLongNullTextInputFormat.java
PRE-CREATION 
>   giraph-examples/src/main/java/org/apache/giraph/examples/scc/SccPhaseMasterCompute.java
PRE-CREATION 
>   giraph-examples/src/main/java/org/apache/giraph/examples/scc/SccVertexValue.java PRE-CREATION

>   giraph-examples/src/main/java/org/apache/giraph/examples/scc/package-info.java PRE-CREATION

>   giraph-examples/src/test/java/org/apache/giraph/examples/scc/SccComputationTestInMemory.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24665/diff/
> 
> 
> Testing
> -------
> 
> This has been tested on a real cluster using two of the Stanford's SNAP datasets. Also,
a new in-memory test is provided in the patch.
> 
> 
> Thanks,
> 
> Gianluca Righetto
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message