Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9F1E011EF3 for ; Fri, 11 Jul 2014 18:42:07 +0000 (UTC) Received: (qmail 83670 invoked by uid 500); 11 Jul 2014 18:42:07 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 83609 invoked by uid 500); 11 Jul 2014 18:42:07 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 83595 invoked by uid 500); 11 Jul 2014 18:42:07 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 83592 invoked by uid 99); 11 Jul 2014 18:42:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jul 2014 18:42:07 +0000 Date: Fri, 11 Jul 2014 18:42:07 +0000 (UTC) From: "Maja Kabiljo (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GIRAPH-928) SendWorkerMessagesRequest should not store messages into PointerList based messagestores MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059173#comment-14059173 ] Maja Kabiljo commented on GIRAPH-928: ------------------------------------- +1 > SendWorkerMessagesRequest should not store messages into PointerList based messagestores > ---------------------------------------------------------------------------------------- > > Key: GIRAPH-928 > URL: https://issues.apache.org/jira/browse/GIRAPH-928 > Project: Giraph > Issue Type: Bug > Reporter: Pavan Kumar > Assignee: Pavan Kumar > Priority: Minor > Attachments: GIRAPH-928, GIRAPH-928.patch > > > While running some test jobs I realized that after GIRAPH-912, some old logic inside SendOneMessageToManyCache can cause a situation where SendWorkerMessagesRequest try to store messages into PointerList based messagestores. This is semantically incorrect. So the code needs to be refactored to remove this possibility. Also adding sanity checks which can be removed later if felt redundant. -- This message was sent by Atlassian JIRA (v6.2#6252)