giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavan Kumar Athivarapu" <pava...@outlook.com>
Subject Re: Review Request 23251: GIRAPH-925 Unit tests should pass even if zookeeper port not available
Date Thu, 03 Jul 2014 01:38:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23251/#review47277
-----------------------------------------------------------


lgtm


- Pavan Kumar Athivarapu


On July 2, 2014, 10:38 p.m., Sergey Edunov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23251/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 10:38 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> I added simple test if port is available and if not, unit test will keep looking for
the next one. 
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 09dd46d

> 
> Diff: https://reviews.apache.org/r/23251/diff/
> 
> 
> Testing
> -------
> 
> Run test cases with 22182 available and unavailable
> 
> 
> Thanks,
> 
> Sergey Edunov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message