Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 081C2104A1 for ; Fri, 6 Jun 2014 00:44:02 +0000 (UTC) Received: (qmail 17237 invoked by uid 500); 5 Jun 2014 23:44:02 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 17159 invoked by uid 500); 5 Jun 2014 23:44:02 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 17084 invoked by uid 500); 5 Jun 2014 23:44:02 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 17061 invoked by uid 99); 5 Jun 2014 23:44:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jun 2014 23:44:02 +0000 Date: Thu, 5 Jun 2014 23:44:02 +0000 (UTC) From: "Tom Schweiger (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GIRAPH-911) Calling setConf on wrapped Input and Output classses. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Schweiger updated GIRAPH-911: --------------------------------- Description: There is a wrapper for vertex and edge input and output format classes that creates a copy of the class and then calls certain methods using a modified context. The wrapped class is configurable, but setConf is never called on it. If a user creates their own vertex or edge input or output format that requires some special set-up, they cannot use the obvious setConf call to achieve this. Thus for the wrapped classes there should be a setConf method that calls the super for the wrapper as well as setConf on the wrapped class. Otherwise, there is no point to calling configureIfPossible on the wrapped class. Priority: Minor (was: Major) Affects Version/s: 1.1.0 Labels: easyfix (was: ) Remaining Estimate: 1h Original Estimate: 1h Summary: Calling setConf on wrapped Input and Output classses. (was: wrapped Input and Output classses.) > Calling setConf on wrapped Input and Output classses. > ------------------------------------------------------ > > Key: GIRAPH-911 > URL: https://issues.apache.org/jira/browse/GIRAPH-911 > Project: Giraph > Issue Type: Bug > Affects Versions: 1.1.0 > Reporter: Tom Schweiger > Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > There is a wrapper for vertex and edge input and output format classes that creates a copy of the class and then calls certain methods using a modified context. The wrapped class is configurable, but setConf is never called on it. If a user creates their own vertex or edge input or output format that requires some special set-up, they cannot use the obvious setConf call to achieve this. Thus for the wrapped classes there should be a setConf method that calls the super for the wrapper as well as setConf on the wrapped class. > Otherwise, there is no point to calling configureIfPossible on the wrapped class. -- This message was sent by Atlassian JIRA (v6.2#6252)