Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EED4111A27 for ; Wed, 4 Jun 2014 16:07:02 +0000 (UTC) Received: (qmail 64533 invoked by uid 500); 4 Jun 2014 16:07:02 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 64495 invoked by uid 500); 4 Jun 2014 16:07:02 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 64475 invoked by uid 500); 4 Jun 2014 16:07:02 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 64454 invoked by uid 99); 4 Jun 2014 16:07:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2014 16:07:02 +0000 Date: Wed, 4 Jun 2014 16:07:02 +0000 (UTC) From: "Pavan Kumar (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GIRAPH-892) Add support for new vertexIdData based data structures MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017806#comment-14017806 ] Pavan Kumar commented on GIRAPH-892: ------------------------------------ Discarded old review & created a new one https://reviews.apache.org/r/22238/ with GIRAPH-907 as its parent > Add support for new vertexIdData based data structures > ------------------------------------------------------ > > Key: GIRAPH-892 > URL: https://issues.apache.org/jira/browse/GIRAPH-892 > Project: Giraph > Issue Type: New Feature > Reporter: Pavan Kumar > Assignee: Pavan Kumar > Attachments: GIRAPH-892.patch, GIRAPH-892_1.patch > > > Currently writableRequests are deserialized from network buffers into a bytearray based datastructure (vertexIdData - ByteArrayVertexIdEdges, ByteArrayVertexIdMessages, etc.) and then immediately stored into MessageStore, EdgeStore, etc. > In this diff we ensure that we can directly read from network buffers (while storing in MessageStore for example) without creating an (unnecessary intermediate ByteArray based) vertexIdData object. -- This message was sent by Atlassian JIRA (v6.2#6252)