giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Schweiger (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-911) Calling setConf on wrapped Input and Output classses.
Date Thu, 05 Jun 2014 23:44:02 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tom Schweiger updated GIRAPH-911:
---------------------------------

           Description: 
There is a wrapper for vertex and edge input and output format classes that creates a copy
of the class and then calls certain methods using a modified context.  The wrapped class is
configurable, but setConf is never called on it.  If a user creates their own vertex or edge
input or output format that requires some special set-up, they cannot use the obvious setConf
call to achieve this.  Thus for the wrapped classes there should be a setConf method that
calls the super for the wrapper as well as setConf on the wrapped class.

Otherwise, there is no point to calling configureIfPossible on the wrapped class.
              Priority: Minor  (was: Major)
     Affects Version/s: 1.1.0
                Labels: easyfix  (was: )
    Remaining Estimate: 1h
     Original Estimate: 1h
               Summary: Calling  setConf on wrapped Input and Output classses.  (was: wrapped
Input and Output classses.)

> Calling  setConf on wrapped Input and Output classses.
> ------------------------------------------------------
>
>                 Key: GIRAPH-911
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-911
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Tom Schweiger
>            Priority: Minor
>              Labels: easyfix
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a wrapper for vertex and edge input and output format classes that creates a
copy of the class and then calls certain methods using a modified context.  The wrapped class
is configurable, but setConf is never called on it.  If a user creates their own vertex or
edge input or output format that requires some special set-up, they cannot use the obvious
setConf call to achieve this.  Thus for the wrapped classes there should be a setConf method
that calls the super for the wrapper as well as setConf on the wrapped class.
> Otherwise, there is no point to calling configureIfPossible on the wrapped class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message