giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-910) removing unnecessary boxing in some places in giraph-core
Date Sun, 08 Jun 2014 19:30:04 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021285#comment-14021285
] 

Hudson commented on GIRAPH-910:
-------------------------------

ABORTED: Integrated in Giraph-trunk-Commit #1446 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1446/])
GIRAPH-910: removing unnecessary boxing in some places in giraph-core (pavanka) (pavanka:
http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=28dac9e5a790199dffe944bad2d518435474b396)
* giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleArrayEdges.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/DoubleMaxAggregator.java
* CHANGELOG
* giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/DoubleDenseVector.java
* giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleHashMapEdges.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/FloatMaxAggregator.java
* giraph-core/src/main/java/org/apache/giraph/edge/LongNullArrayEdges.java
* giraph-core/src/main/java/org/apache/giraph/edge/IntNullArrayEdges.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/FloatDenseVector.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/LongDenseVector.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/IntDenseVector.java


> removing unnecessary boxing in some places in giraph-core
> ---------------------------------------------------------
>
>                 Key: GIRAPH-910
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-910
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Pavan Kumar
>            Assignee: Pavan Kumar
>            Priority: Minor
>         Attachments: GIRAPH-910.patch
>
>
> There is a lot of boxing with regards to partition - which is always int?
> i.e. methods in PartitionStore have no reason to be Integers.
> Also Float.MIN_VALUE is smallest positive value, so all those are not correct



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message