giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavan Kumar Athivarapu" <pava...@outlook.com>
Subject Re: Review Request 21987: Detect crashes of Netty threads
Date Thu, 26 Jun 2014 01:28:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21987/#review46705
-----------------------------------------------------------

Ship it!


Ship It!

- Pavan Kumar Athivarapu


On June 25, 2014, 7:52 p.m., Sergey Edunov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21987/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 7:52 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> When some of the request processing threads fails, the worker gets stuck but the job
doesn't fail and it has to be killed manually. We should detect netty thread crashes and fail
the job automatically.
> 
> 
> Diffs
> -----
> 
>   findbugs-exclude.xml e0466f7 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ae40c3b 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyMasterClient.java c982209

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyMasterServer.java cb36c3e

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyServer.java 14d4ea8 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 7541418

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java adb96cb

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/MasterRequestServerHandler.java
3e06026 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java
b6d0533 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/WorkerRequestServerHandler.java
f64c373 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphMapper.java c86a024 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java e13eedd 
>   giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 02d4f2b 
>   giraph-core/src/main/java/org/apache/giraph/utils/ThreadUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java dbe6a45 
>   giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnTask.java f4719cc 
>   giraph-core/src/test/java/org/apache/giraph/comm/ConnectionTest.java e771e36 
>   giraph-core/src/test/java/org/apache/giraph/comm/MockExceptionHandler.java PRE-CREATION

>   giraph-core/src/test/java/org/apache/giraph/comm/RequestFailureTest.java 157a543 
>   giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java 32454f4 
>   giraph-core/src/test/java/org/apache/giraph/comm/SaslConnectionTest.java c026cf8 
> 
> Diff: https://reviews.apache.org/r/21987/diff/
> 
> 
> Testing
> -------
> 
> Run some production jobs with this change. 
> Also introduced random bugs in deserialization logic and confirmed that job fails. 
> 
> 
> Thanks,
> 
> Sergey Edunov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message