Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2216712D01 for ; Sun, 11 May 2014 01:43:59 +0000 (UTC) Received: (qmail 69049 invoked by uid 500); 10 May 2014 22:02:50 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 47903 invoked by uid 500); 10 May 2014 22:01:26 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 12099 invoked by uid 99); 10 May 2014 21:58:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 21:58:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9FBEE1D79BE; Thu, 8 May 2014 21:59:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1952027949067131547==" MIME-Version: 1.0 Subject: Re: Review Request 21151: Giraph-886 - Partition Balancing does not work From: "Pavan Kumar Athivarapu" To: "Avery Ching" , "Maja Kabiljo" , "Sebastian Schelter" , "Claudio Martella" , "pavan kumar kolamuri" Cc: "Lukas Nalezenec" , "giraph" , "Pavan Kumar Athivarapu" Date: Thu, 08 May 2014 21:59:18 -0000 Message-ID: <20140508215918.25724.45058@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Pavan Kumar Athivarapu" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/21151/ X-Sender: "Pavan Kumar Athivarapu" References: <20140507103330.28778.29079@reviews.apache.org> In-Reply-To: <20140507103330.28778.29079@reviews.apache.org> Reply-To: "Pavan Kumar Athivarapu" X-ReviewRequest-Repository: giraph-git --===============1952027949067131547== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21151/#review42543 ----------------------------------------------------------- I am not sure if u wanted to include me - (perhaps name mismatch) if u want I can review this over weekend. glancing over this seems good - your comment is valid. we assume sorted [& also that partitions are consequtive] - Pavan Kumar Athivarapu On May 7, 2014, 10:33 a.m., Lukas Nalezenec wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21151/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 10:33 a.m.) > > > Review request for giraph, Avery Ching, Claudio Martella, Maja Kabiljo, pavan kumar kolamuri, and Sebastian Schelter. > > > Repository: giraph-git > > > Description > ------- > > PartitionBalancer returns PartitionOwners in list in arbitrary order but both Range and Hash partitioners are assuming that list is sorted by partitionId. > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 7ab291b > giraph-core/src/main/java/org/apache/giraph/partition/HashWorkerPartitioner.java d833895 > giraph-core/src/main/java/org/apache/giraph/partition/PartitionBalancer.java 3454d62 > giraph-core/src/main/java/org/apache/giraph/partition/SimpleWorkerPartitioner.java 600d7a3 > > Diff: https://reviews.apache.org/r/21151/diff/ > > > Testing > ------- > > > Thanks, > > Lukas Nalezenec > > --===============1952027949067131547==--