giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Muchinsky" <cmuch...@us.ibm.com>
Subject Re: Review Request 19405: GIRAPH-874 - Specialized byte array partitions
Date Fri, 21 Mar 2014 16:22:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19405/
-----------------------------------------------------------

(Updated March 21, 2014, 4:22 p.m.)


Review request for giraph.


Changes
-------

Updated patch with a few minor simplifications and file mode changes


Repository: giraph-git


Description
-------

This patch adds 2 new byte array partition variations that are optimized for int/long ids.
They leverage fastutil primitive maps and allow for vertex object reuse during iteration because
they don't keep a reference to the vertexId object in the primitive map.

Additional unit tests were added to TestPartitionStores which cover the new IntByteArrayPartition
class, which is functionally identical to LongByteArrayPartition.


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/partition/primitives/IntByteArrayPartition.java
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/partition/primitives/LongByteArrayPartition.java
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/partition/primitives/package-info.java PRE-CREATION

  giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java 08f4544 

Diff: https://reviews.apache.org/r/19405/diff/


Testing
-------

Successful "mvn clean verify" with hadoop_2 profile, and 4B vertex 5B edge graph tested on
18 node 432 core cluster.


Thanks,

Craig Muchinsky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message