giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-856) Log amount of free memory on the command line
Date Sat, 22 Feb 2014 14:51:19 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909398#comment-13909398
] 

Avery Ching commented on GIRAPH-856:
------------------------------------

This is neat.  A few comments below.

CombinedWorkerProgress
- All the member variables can be final (even the ones before this change)

I'm a little confused by 
freeMemoryMB += minFreeMemoryMB;

and what freeMemoryMB is supposed to represent in CombinedWorkerProgress.  It appears to be
an average, but it is supposed to be an average free memory MB on all workers rather than
an average of the min free memory MB?


> Log amount of free memory on the command line
> ---------------------------------------------
>
>                 Key: GIRAPH-856
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-856
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-856.patch
>
>
> Very useful when checking whether application is healthy is to know if some of the workers
has memory issues - we should track minimal amount of free memory on the command line.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message