giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Schelter" <...@apache.org>
Subject Re: Review Request 18457: GIRAPH-860
Date Tue, 25 Feb 2014 07:38:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18457/#review35378
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Schelter


On Feb. 25, 2014, 6:55 a.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18457/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 6:55 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Bugs: GIRAPH-860
>     https://issues.apache.org/jira/browse/GIRAPH-860
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> Fixes an issue where the closing filestamps are attempted once and may fail, hanging
the job forever.  Now the logic is to retry for a fixed amount of times with a delay and then
fail the job, rather than hang it forever.
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java ea1f12def8cea6f2697a508d536d49689a3f813a

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 732827c4894a08b5c16dd8676cd944dce5786f31

>   giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java 66f627f6a5d842bd04123f89ea052cf3ab733736

> 
> Diff: https://reviews.apache.org/r/18457/diff/
> 
> 
> Testing
> -------
> 
> mvn clean verify
> 
> 
> Thanks,
> 
> Avery Ching
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message