giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-724) UnsafeByteArrayOutputStream.writeUTF should call ensureSize
Date Wed, 15 Jan 2014 20:16:19 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872541#comment-13872541
] 

Maja Kabiljo commented on GIRAPH-724:
-------------------------------------

In writeBytes/writeChars/writeUTF, we can just call writeChar/writeByte/writeShort methods
which already do it all (check the size, call unsafe, move position).

> UnsafeByteArrayOutputStream.writeUTF should call ensureSize
> -----------------------------------------------------------
>
>                 Key: GIRAPH-724
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-724
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>         Attachments: GIRAPH-724.patch, GIRAPH-724.patch, GIRAPH-724.patch
>
>
> UnsafeByteArrayOutputStream.writeUTF can throw an exception if the String doesn't fit
in current byte array because ensureSize is not called.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message