giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Jensen <greg.jensen...@gmail.com>
Subject Re: [jira] [Commented] (GIRAPH-724) UnsafeByteArrayOutputStream.writeUTF should call ensureSize
Date Wed, 15 Jan 2014 22:28:01 GMT
Maja,
    I had found this same bug a couple of weeks ago and was working on 
the patch. Attached is the unit tests I was working on.  It was still a 
work in progress, but I hope you find it useful.

On 1/15/2014 3:16 PM, Maja Kabiljo (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/GIRAPH-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872541#comment-13872541
]
>
> Maja Kabiljo commented on GIRAPH-724:
> -------------------------------------
>
> In writeBytes/writeChars/writeUTF, we can just call writeChar/writeByte/writeShort methods
which already do it all (check the size, call unsafe, move position).
>
>> UnsafeByteArrayOutputStream.writeUTF should call ensureSize
>> -----------------------------------------------------------
>>
>>                  Key: GIRAPH-724
>>                  URL: https://issues.apache.org/jira/browse/GIRAPH-724
>>              Project: Giraph
>>           Issue Type: Bug
>>             Reporter: Maja Kabiljo
>>          Attachments: GIRAPH-724.patch, GIRAPH-724.patch, GIRAPH-724.patch
>>
>>
>> UnsafeByteArrayOutputStream.writeUTF can throw an exception if the String doesn't
fit in current byte array because ensureSize is not called.
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1.5#6160)
>


Mime
View raw message