giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-798) Upgrade Giraph to Java7 and fix all dependencies
Date Mon, 16 Dec 2013 18:03:07 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849400#comment-13849400
] 

Avery Ching commented on GIRAPH-798:
------------------------------------

Claudio,

Let me attempt to clarify a bit.

None of these issues were blocking the move to Java 7.  There are two parts to this JIRA.
1)  Upgrade to Java 7. 
Note that there are very few lines of change for this.  It does not address the dependencies
issues or duplicate class issues.  It would simply be an upgrade to Java 7.   It is totally
separate from the duplicate classes, dependency issues.  Moving to Java 7 does not break the
build, it simply upgrades us to Java 7, a supported version of Java (something we should definitely
do).
2)  I tried to improve Giraph by fixing as many of the dependency issues and duplicate classes
issues.  This is a general code quality issue that is better for all profiles, but especially
better for a few.  Due to munge, it is nearly impossible to fix all of them perfectly.  I.e.
changing one dependency for one can mess up another.  These changes only help to improve the
code base.

I agree that I didn't test the other profiles adequately.  I addressed that in GIRAPH-815.
 Sorry for the intermittent breakage.  But overall, after these two patches, IMO, put Giraph
in a better state.  The outcome is
1)  We are finally on Java 7 (Java 6 is no longer supported).
2)  Some of the profiles have eliminated or mitigate almost all of the duplicate classes and
multiple library versions issues that have always existed.  The other profiles are certainly
improved, but not perfectly fixed yet.

I hope this helps to explain the issue.

https://issues.apache.org/jira/browse/GIRAPH-101 was an attempt by a Girapher to fix the munge
issue.  I'm hoping to find some time early next year to take a crack at it if no one gets
to it by then.  

> Upgrade Giraph to Java7 and fix all dependencies
> ------------------------------------------------
>
>                 Key: GIRAPH-798
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-798
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-YARN-COMPILE.patch, GIRAPH-ZOOKEEPER34.patch
>
>
> We need to upgrade to Java 7, Java 6 is no longer supported and Java 7 provides a lot
of great new features.
> Additionally, we have a mess of dependencies.
> Incompatible versions, unspecified dependencies, and duplicate classes.  We will add
checks for all of them.
> For now, full checks are provided for the profiles
> hadoop_0.20.203
> hadoop_1.0
> hadoop_facebook
> Also, the hcatalog module is not fully fixed and excluded from the checking.  We can
fix this in the future.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message