Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC61510569 for ; Sat, 9 Nov 2013 17:16:10 +0000 (UTC) Received: (qmail 80425 invoked by uid 500); 9 Nov 2013 17:16:09 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 80343 invoked by uid 500); 9 Nov 2013 17:16:07 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 80333 invoked by uid 99); 9 Nov 2013 17:16:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Nov 2013 17:16:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3B1711C43B0; Sat, 9 Nov 2013 17:16:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2349876671955130861==" MIME-Version: 1.0 Subject: Re: Review Request 15378: Create EdgeInputFormat from Apache Gora From: "Claudio Martella" To: "Claudio Martella" Cc: "Renato Marroquin" , "giraph" Date: Sat, 09 Nov 2013 17:16:03 -0000 Message-ID: <20131109171603.31710.43438@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Claudio Martella" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/15378/ X-Sender: "Claudio Martella" References: <20131108232126.28955.73505@reviews.apache.org> In-Reply-To: <20131108232126.28955.73505@reviews.apache.org> Reply-To: "Claudio Martella" X-ReviewRequest-Repository: giraph-git --===============2349876671955130861== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15378/#review28621 ----------------------------------------------------------- looks good. please fix the usual stuff. - Claudio Martella On Nov. 8, 2013, 11:21 p.m., Renato Marroquin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15378/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 11:21 p.m.) > > > Review request for giraph and Claudio Martella. > > > Repository: giraph-git > > > Description > ------- > > Create EdgeInputFormat from Apache Gora > > > Diffs > ----- > > giraph-gora/conf/edge.avsc PRE-CREATION > giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION > giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION > giraph-gora/conf/gora.properties PRE-CREATION > giraph-gora/conf/vertex.json PRE-CREATION > giraph-gora/conf/zoo.cfg PRE-CREATION > giraph-gora/pom.xml PRE-CREATION > giraph-gora/src/main/assembly/compile.xml PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraEdgeInputFormat.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGEdgeEdgeInputFormat.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GEdge.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION > giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestEdgeInputFormat.java PRE-CREATION > giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraEdgeInputFormat.java PRE-CREATION > pom.xml cc2c9a8 > > Diff: https://reviews.apache.org/r/15378/diff/ > > > Testing > ------- > > Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies. > > > Thanks, > > Renato Marroquin > > --===============2349876671955130861==--