Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AE8E104F1 for ; Sat, 9 Nov 2013 16:53:46 +0000 (UTC) Received: (qmail 54288 invoked by uid 500); 9 Nov 2013 16:53:45 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 54065 invoked by uid 500); 9 Nov 2013 16:53:44 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 54055 invoked by uid 99); 9 Nov 2013 16:53:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Nov 2013 16:53:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D29B51C43B0; Sat, 9 Nov 2013 16:53:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4910702078503386242==" MIME-Version: 1.0 Subject: Re: Review Request 15376: Create VertexInputFormat from Apache Gora From: "Claudio Martella" To: "Claudio Martella" Cc: "Renato Marroquin" , "giraph" Date: Sat, 09 Nov 2013 16:53:40 -0000 Message-ID: <20131109165340.31711.94575@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Claudio Martella" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/15376/ X-Sender: "Claudio Martella" References: <20131108231353.28955.49255@reviews.apache.org> In-Reply-To: <20131108231353.28955.49255@reviews.apache.org> Reply-To: "Claudio Martella" X-ReviewRequest-Repository: giraph-git --===============4910702078503386242== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15376/#review28617 ----------------------------------------------------------- giraph-gora/pom.xml are all these spaces necessary? giraph-gora/pom.xml i thought we did not need this. giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexInputFormat.java you may want to specify that this is an example? giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexInputFormat.java not sure this should be an error(). i can imagine it must be common to load the whole key range? giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java also here, you may want to specify this is an example. giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java remove space before "=" - Claudio Martella On Nov. 8, 2013, 11:13 p.m., Renato Marroquin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15376/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 11:13 p.m.) > > > Review request for giraph and Claudio Martella. > > > Repository: giraph-git > > > Description > ------- > > Create VertexInputFormat from Apache Gora > > > Diffs > ----- > > giraph-gora/conf/edge.avsc PRE-CREATION > giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION > giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION > giraph-gora/conf/gora.properties PRE-CREATION > giraph-gora/conf/vertex.json PRE-CREATION > giraph-gora/conf/zoo.cfg PRE-CREATION > giraph-gora/pom.xml PRE-CREATION > giraph-gora/src/main/assembly/compile.xml PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexInputFormat.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexInputFormat.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION > giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION > giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexInputFormat.java PRE-CREATION > giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexInputFormat.java PRE-CREATION > pom.xml cc2c9a8 > > Diff: https://reviews.apache.org/r/15376/diff/ > > > Testing > ------- > > Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies. > > > Thanks, > > Renato Marroquin > > --===============4910702078503386242==--