giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo" <>
Subject Review Request 14585: GIRAPH-778: Testing with TestGraph is broken
Date Fri, 11 Oct 2013 00:17:44 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for giraph.

Bugs: GIRAPH-778

Repository: giraph-git


TestGraph was never really working correctly, since for example newly created vertices wouldn't
be a part of it, deleted vertices would still be there, it won't work with ByteArrayPartition...
But after GIRAPH-775 it's completely useless since all vertices from input format are serialized
and deserialized to other objects.
I added InMemoryVertexOutputFormat which stores all vertices in its static field TestGraph.
Now when running InternalVertexRunner.runWithInMemoryOutput all vertices will be stored to
this TestGraph.


  giraph-core/src/main/java/org/apache/giraph/bsp/ e5480cc 
  giraph-core/src/main/java/org/apache/giraph/io/formats/ PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/utils/ 72fab83 
  giraph-core/src/main/java/org/apache/giraph/utils/ 312a287 
  giraph-core/src/test/java/org/apache/giraph/master/ e96fd12 



mvn clean verify

I don't understand why, but when we all tests together nothing fails, however with current
code running ConnectedComponentsComputationTestInMemory separately fails. With this patch
it succeeds.


Maja Kabiljo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message