giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Armando" <>
Subject Re: Review Request 14046: GIRAPH-755: Make ZooKeeper port list available to input/output format
Date Sun, 15 Sep 2013 11:51:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 15, 2013, 11:51 a.m.)

Review request for giraph.


sorry, uploaded the previous patch in the wrong place

Repository: giraph-git


This patch is intended to refactor the way zookeeper list is kept in the configuration. In
this manner the list is available also in other classes different from the services (BspService)
which may benefit of zookeeper functionalities.

I introduce the change of semantic of this type:
conf.getZookeeperList() != null   is equivalent to  conf.isZookeeperExternal()

Diffs (updated)

  giraph-core/src/main/java/org/apache/giraph/bsp/ aae01da 
  giraph-core/src/main/java/org/apache/giraph/conf/ 15ff861 
  giraph-core/src/main/java/org/apache/giraph/conf/ 604729a 
  giraph-core/src/main/java/org/apache/giraph/graph/ 704fb9e 
  giraph-core/src/main/java/org/apache/giraph/master/ 454c934 
  giraph-core/src/main/java/org/apache/giraph/worker/ 112b76d 
  giraph-core/src/main/java/org/apache/giraph/yarn/ 341db0e 



mvn verify with java 6 passed.



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message