giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Armando" <a.mirag...@student.vu.nl>
Subject Re: Review Request 14046: GIRAPH-755: Make ZooKeeper port list available to input/output format
Date Sun, 15 Sep 2013 11:51:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14046/
-----------------------------------------------------------

(Updated Sept. 15, 2013, 11:51 a.m.)


Review request for giraph.


Changes
-------

sorry, uploaded the previous patch in the wrong place


Repository: giraph-git


Description
-------

This patch is intended to refactor the way zookeeper list is kept in the configuration. In
this manner the list is available also in other classes different from the services (BspService)
which may benefit of zookeeper functionalities.

I introduce the change of semantic of this type:
conf.getZookeeperList() != null   is equivalent to  conf.isZookeeperExternal()


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java aae01da 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 15ff861 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 604729a 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 704fb9e 
  giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 454c934 
  giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 112b76d 
  giraph-core/src/main/java/org/apache/giraph/yarn/GiraphYarnClient.java 341db0e 

Diff: https://reviews.apache.org/r/14046/diff/


Testing
-------

mvn verify with java 6 passed.


Thanks,

Armando


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message