giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Herald Kllapi" <heral...@gmail.com>
Subject Re: Review Request 14025: Dense matrix aggregator implementation.
Date Wed, 11 Sep 2013 05:50:37 GMT


> On Sept. 11, 2013, 5:08 a.m., Alessandro Presta wrote:
> > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/DoubleDenseVector.java,
line 31
> > <https://reviews.apache.org/r/14025/diff/3/?file=350646#file350646line31>
> >
> >     to -> too

done!


> On Sept. 11, 2013, 5:08 a.m., Alessandro Presta wrote:
> > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/DoubleDenseVector.java,
line 34
> > <https://reviews.apache.org/r/14025/diff/3/?file=350646#file350646line34>
> >
> >     Now it's way too detailed.
> >     It suffices to say that we have additional fields to compactly represent vectors
with a single nonzero coordinate, and this is used to efficiently perform aggregations.

done! :-)


- Herald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14025/#review26032
-----------------------------------------------------------


On Sept. 11, 2013, 1:58 a.m., Herald Kllapi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14025/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 1:58 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> In applications where a matrix is needed, is not efficient to have an aggregator per
entry. This update provides the same functionality with an aggregator per matrix row. This
implementation uses an array per row and is efficient when the matrices are dense.
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrix.java d86dc4b68700e328eb730a25a1d3b9f828c52bb4

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrixSumAggregator.java
0a1dafbc6e1c30294d1d1b460b405106ed75e113 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVector.java 288be93bafa8bed1e8194c28581e7d25d222ec18

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVectorSumAggregator.java
33185546c686f830d6b62549b249d80375cd89f6 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrix.java 67bad5c1cb9c893974da87c8095d3792ae6a4902

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrixSumAggregator.java
54406ed0897316d66d0f052fc1c396b72650e519 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVector.java 6efe81e9d148a6525b2a13f92c7ea015a0efd147

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVectorSumAggregator.java
b152395b38df7b7c37a7d21cb62762b3062882cf 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrix.java 624c7937d7a1b74bd5f9a8a78d70bf62c11128e7

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrixSumAggregator.java
b7afa60655071bec9cd963259632d6b54d6ff06b 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVector.java e5bb400b5488f2c4fd821311a17e5f4b7c83d2bf

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVectorSumAggregator.java
b588331b26ea8ddd5fc8a999d05ba0f74ca306cf 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrix.java dbc3ecb3d09d3062308bd8054b0dd5471b2a605e

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrixSumAggregator.java
a7dc186ea9d4722d29b0ee37a568d61a15b31b37 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVector.java 6781b4397c2e4aecd39b2aaee13923bf36bf85c6

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVectorSumAggregator.java
ed35e15492f8e2c73cf426c670a645ee86ceabd7 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/MatrixSumAggregator.java
38644723786c23fd62e562bb2e0c8cab02c10aab 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/DoubleDenseMatrix.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/DoubleDenseMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/DoubleDenseVector.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/DoubleDenseVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/FloatDenseMatrix.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/FloatDenseMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/FloatDenseVector.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/FloatDenseVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/IntDenseMatrix.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/IntDenseMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/IntDenseVector.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/IntDenseVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/LongDenseMatrix.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/LongDenseMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/LongDenseVector.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/LongDenseVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/dense/package-info.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/sparse/package-info.java
PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestDoubleMatrix.java
d67eda17d9cd25f915e962b816cc79c0ac7a95ae 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestFloatMatrix.java
d0f9bb01ba7102f86cf671183c3bfa54e45c9240 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestIntMatrix.java e8d3561aaace1a4bdc80c98f94a7dd2a1dbf4afb

>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestLongMatrix.java
a0a7000d37116cebf528e4bc6750f43afc217ee2 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/dense/TestDoubleDenseMatrix.java
PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/dense/TestFloatDenseMatrix.java
PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/dense/TestIntDenseMatrix.java
PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/dense/TestLongDenseMatrix.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14025/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Herald Kllapi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message