Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 04D55F509 for ; Tue, 6 Aug 2013 06:39:01 +0000 (UTC) Received: (qmail 40761 invoked by uid 500); 6 Aug 2013 06:38:59 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 40715 invoked by uid 500); 6 Aug 2013 06:38:58 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 40705 invoked by uid 99); 6 Aug 2013 06:38:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2013 06:38:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1C13D1D207E; Tue, 6 Aug 2013 06:38:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1956869880043056984==" MIME-Version: 1.0 Subject: Re: Review Request 13248: Added support for matrix aggregators. We use one aggregator per row and handle the aggregation of entries. The types supported are int, long, float, double. From: "Herald Kllapi" To: "giraph" , "Alessandro Presta" , "Herald Kllapi" Date: Tue, 06 Aug 2013 06:38:55 -0000 Message-ID: <20130806063855.5385.32438@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Herald Kllapi" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/13248/ X-Sender: "Herald Kllapi" References: <20130806030518.5384.988@reviews.apache.org> In-Reply-To: <20130806030518.5384.988@reviews.apache.org> Reply-To: "Herald Kllapi" --===============1956869880043056984== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Aug. 6, 2013, 3:05 a.m., Alessandro Presta wrote: > > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrixSumAggregator.java, line 51 > > > > > > I would add a getRowAggregatorName(i) method. I know it's more characters to type but it's more robust. > > You can put that in a common abstract class (MatrixSumAggregator). name will be a field of that class, and you call super(name) in the children constructors. > > Makes sense? yes! done! - Herald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13248/#review24694 ----------------------------------------------------------- On Aug. 6, 2013, 6:38 a.m., Herald Kllapi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13248/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 6:38 a.m.) > > > Review request for giraph. > > > Repository: giraph-git > > > Description > ------- > > In applications where a matrix is needed, is not efficient to have an aggregator per entry. This update provides the same functionality with an aggregator per matrix row. > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrix.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrixSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVector.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVectorSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrix.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrixSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVector.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVectorSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrix.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrixSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVector.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVectorSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrix.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrixSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVector.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVectorSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/MatrixSumAggregator.java PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/package-info.java PRE-CREATION > giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestDoubleMatrix.java PRE-CREATION > giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestFloatMatrix.java PRE-CREATION > giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestIntMatrix.java PRE-CREATION > giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestLongMatrix.java PRE-CREATION > > Diff: https://reviews.apache.org/r/13248/diff/ > > > Testing > ------- > > We provide test classes to test the functionality. > > > Thanks, > > Herald Kllapi > > --===============1956869880043056984==--