Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 81BF610AD6 for ; Mon, 5 Aug 2013 18:26:08 +0000 (UTC) Received: (qmail 37475 invoked by uid 500); 5 Aug 2013 18:26:08 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 37432 invoked by uid 500); 5 Aug 2013 18:26:07 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 37422 invoked by uid 99); 5 Aug 2013 18:26:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Aug 2013 18:26:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2A4A31D1E4E; Mon, 5 Aug 2013 18:26:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5538311731507000461==" MIME-Version: 1.0 Subject: Re: Review Request 13248: Added support for matrix aggregators. We use one aggregator per row and handle the aggregation of entries. The types supported are int, long, float, double. From: "Herald Kllapi" To: "giraph" , "Alessandro Presta" , "Herald Kllapi" Date: Mon, 05 Aug 2013 18:26:01 -0000 Message-ID: <20130805182601.5384.67186@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Herald Kllapi" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/13248/ X-Sender: "Herald Kllapi" References: <20130802230748.19836.27465@reviews.apache.org> In-Reply-To: <20130802230748.19836.27465@reviews.apache.org> Reply-To: "Herald Kllapi" --===============5538311731507000461== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13248/ ----------------------------------------------------------- (Updated Aug. 5, 2013, 6:25 p.m.) Review request for giraph. Changes ------- Made the requested changes. Removed Check and InMemoryIO. Repository: giraph-git Description ------- In applications where a matrix is needed, is not efficient to have an aggregator per entry. This update provides the same functionality with an aggregator per matrix row. Diffs (updated) ----- giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrix.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrixSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVector.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVectorSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrix.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrixSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVector.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVectorSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrix.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrixSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVector.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVectorSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrix.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrixSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVector.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVectorSumAggregator.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/package-info.java PRE-CREATION giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestDoubleMatrix.java PRE-CREATION giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestFloatMatrix.java PRE-CREATION giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestIntMatrix.java PRE-CREATION giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestLongMatrix.java PRE-CREATION Diff: https://reviews.apache.org/r/13248/diff/ Testing ------- We provide test classes to test the functionality. Thanks, Herald Kllapi --===============5538311731507000461==--