Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C8E22102E6 for ; Tue, 23 Jul 2013 14:19:02 +0000 (UTC) Received: (qmail 79475 invoked by uid 500); 23 Jul 2013 14:19:00 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 79435 invoked by uid 500); 23 Jul 2013 14:18:58 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 79403 invoked by uid 99); 23 Jul 2013 14:18:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2013 14:18:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 47E621C9B41; Tue, 23 Jul 2013 14:18:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6905916135139512483==" MIME-Version: 1.0 Subject: Re: Review Request 12813: GIRAPH-549: Rexter InputFormat From: "Claudio Martella" To: "Armando" , "giraph" , "Claudio Martella" Date: Tue, 23 Jul 2013 14:18:57 -0000 Message-ID: <20130723141857.4976.67391@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Claudio Martella" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/12813/ X-Sender: "Claudio Martella" References: <20130723141743.4985.56622@reviews.apache.org> In-Reply-To: <20130723141743.4985.56622@reviews.apache.org> Reply-To: "Claudio Martella" --===============6905916135139512483== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On July 23, 2013, 2:17 p.m., Armando wrote: > > Looks very good time. Some comments: > > > > 1) Gremlin is actually spelt with an E and not Gramlin > > 2) I think the default hostname should be "", as the default 127.0.0.1 can be misleading > > 3) You can probably live without the gremlin enable property and just infer it by the existence of one of the two other parameters (for edges or vertices) > > 4) Could be an improvement to use a commons lib to actually build the HTTP url instead of manual String. I'm sure it works, but it could help. :) this is actually my review. - Claudio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12813/#review23637 ----------------------------------------------------------- On July 22, 2013, 1:55 p.m., Armando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12813/ > ----------------------------------------------------------- > > (Updated July 22, 2013, 1:55 p.m.) > > > Review request for giraph. > > > Repository: giraph-git > > > Description > ------- > > This patch provides support for Rexster in Giraph via an Input Format. The main classes are RexsterVertexInputFormat and RexsterEdgeInputFormat which can be extended by the user to implement customary InputFormats for Rexster. The patch also includes: > (a) support for gremlin scripts > (b) tests on the example user classes > (c) a page documentation about the InputFormat and how this can be used. > > > Diffs > ----- > > giraph-rexster/pom.xml PRE-CREATION > giraph-rexster/src/main/assembly/compile.xml PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/conf/GiraphRexsterConstants.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/conf/package-info.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterEdgeInputFormat.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterInputSplit.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterVertexInputFormat.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongDoubleFloatVertexInputFormat.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongFloatEdgeInputFormat.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/package-info.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/package-info.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/utils/RexsterUtils.java PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/utils/package-info.java PRE-CREATION > giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestAbstractRexsterInputFormat.java PRE-CREATION > giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatVertexInputFormat.java PRE-CREATION > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/empty-db.input.json PRE-CREATION > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/rexster.xml PRE-CREATION > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/test-db.input.json PRE-CREATION > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/test-db.output.json PRE-CREATION > pom.xml 1131a56 > src/site/site.xml 561fbc0 > src/site/xdoc/rexster.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/12813/diff/ > > > Testing > ------- > > I tested: > (a) empty database > (b) a toy database without query > (c) a toy database using a gremlin query > > I tested both with TinkerGraph and with Neo4jGraph > > > Thanks, > > Armando > > --===============6905916135139512483==--