Return-Path: 
 <dev-return-8188-apmail-giraph-dev-archive=giraph.apache.org@giraph.apache.org>
X-Original-To: apmail-giraph-dev-archive@www.apache.org
Delivered-To: apmail-giraph-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A08CF10CF6
	for <apmail-giraph-dev-archive@www.apache.org>;
 Tue, 16 Jul 2013 23:33:43 +0000 (UTC)
Received: (qmail 47415 invoked by uid 500); 16 Jul 2013 23:33:43 -0000
Delivered-To: apmail-giraph-dev-archive@giraph.apache.org
Received: (qmail 47379 invoked by uid 500); 16 Jul 2013 23:33:43 -0000
Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@giraph.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@giraph.apache.org>
List-Post: <mailto:dev@giraph.apache.org>
List-Id: <dev.giraph.apache.org>
Reply-To: dev@giraph.apache.org
Delivered-To: mailing list dev@giraph.apache.org
Received: (qmail 47369 invoked by uid 99); 16 Jul 2013 23:33:43 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2013 23:33:43 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 5688C1C8FB6;
	Tue, 16 Jul 2013 23:33:43 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4890090328149430911=="
MIME-Version: 1.0
Subject: Re: Review Request 12174: Add "one-to-all" message sending strategy
From: "Bingjing Zhang" <jessezbj@gmail.com>
To: "Avery Ching" <avery.ching@gmail.com>, "giraph" <dev@giraph.apache.org>,
 "Bingjing Zhang" <jessezbj@gmail.com>
Date: Tue, 16 Jul 2013 23:33:43 -0000
Message-ID: <20130716233343.1154.21461@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Bingjing Zhang" <noreply@reviews.apache.org>
X-ReviewGroup: giraph
X-ReviewRequest-URL: https://reviews.apache.org/r/12174/
X-Sender: "Bingjing Zhang" <noreply@reviews.apache.org>
References: <20130710211308.14364.54544@reviews.apache.org>
In-Reply-To: <20130710211308.14364.54544@reviews.apache.org>
Reply-To: "Bingjing Zhang" <jessezbj@gmail.com>

--===============4890090328149430911==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12174/
-----------------------------------------------------------

(Updated July 16, 2013, 11:33 p.m.)


Review request for giraph.


Changes
-------

Add new interface sendMessageToMultipleEdges(Iterator<I> vertexIdIterator, M message) to allow sending to a set of target vertex ids.


Bugs: GIRAPH-701
    https://issues.apache.org/jira/browse/GIRAPH-701


Repository: giraph-git


Description
-------

Add "one-to-all" message sending strategy.
Now when sendMessageToAllEdges is invoked, Giraph may apply "one-to-all" message sending strategy.
To enable it, use conf.enableOneToAllMsgSending() 


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java ff3f06d 
  giraph-core/src/main/java/org/apache/giraph/comm/SendCache.java 92d0926 
  giraph-core/src/main/java/org/apache/giraph/comm/SendMessageCache.java 2eeac18 
  giraph-core/src/main/java/org/apache/giraph/comm/SendMessageToAllCache.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java a50f673 
  giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 89fb3e4 
  giraph-core/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java bedaf48 
  giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java 7ce0083 
  giraph-core/src/main/java/org/apache/giraph/comm/requests/RequestType.java 4129fb8 
  giraph-core/src/main/java/org/apache/giraph/comm/requests/SendWorkerOneToAllMessagesRequest.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 21cf245 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java c4cc96f 
  giraph-core/src/main/java/org/apache/giraph/counters/GiraphStats.java 3f25508 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 87d5879 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java a9bf3fd 
  giraph-core/src/main/java/org/apache/giraph/graph/GlobalStats.java f3cbea2 
  giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 1d3cff0 
  giraph-core/src/main/java/org/apache/giraph/metrics/MetricNames.java cc237ac 
  giraph-core/src/main/java/org/apache/giraph/partition/PartitionStats.java b8eeca9 
  giraph-core/src/main/java/org/apache/giraph/utils/ByteArrayOneToAllMessages.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/utils/ByteArrayVertexIdData.java 26c547b 
  giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 52bac3f 
  giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java 2e60c09 
  giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java bc5b5e2 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingComputationTest.java 7346745 

Diff: https://reviews.apache.org/r/12174/diff/


Testing
-------

Did
mvn clean verify
mvn clean test


Thanks,

Bingjing Zhang


--===============4890090328149430911==--