Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21515101F0 for ; Mon, 15 Jul 2013 20:56:28 +0000 (UTC) Received: (qmail 72745 invoked by uid 500); 15 Jul 2013 20:56:28 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 72713 invoked by uid 500); 15 Jul 2013 20:56:28 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 72704 invoked by uid 99); 15 Jul 2013 20:56:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jul 2013 20:56:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DD6841CF415; Mon, 15 Jul 2013 20:56:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4512529663991836346==" MIME-Version: 1.0 Subject: Review Request 12559: GIRAPH-716: Stop modifying Configuration since it's not thread-safe From: "Maja Kabiljo" To: "Maja Kabiljo" , "giraph" Date: Mon, 15 Jul 2013 20:56:17 -0000 Message-ID: <20130715205617.28534.67342@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maja Kabiljo" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/12559/ X-Sender: "Maja Kabiljo" Reply-To: "Maja Kabiljo" --===============4512529663991836346== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12559/ ----------------------------------------------------------- Review request for giraph. Bugs: GIRAPH-716 https://issues.apache.org/jira/browse/GIRAPH-716 Repository: giraph-git Description ------- It seems GIRAPH-694 wasn't enough, since we got similar problems again. We should not modify Configurations, but create copies when we need them. There were some issues in hive-io which prevented us from doing this in the first place, which are fixed now. Diffs ----- giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 74f1ba5 giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeInputFormat.java c3adf4c giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeReader.java e3b3689 giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexInputFormat.java a58a32d giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexOutputFormat.java bffa330 giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexReader.java bf0a212 giraph-core/src/main/java/org/apache/giraph/job/HadoopUtils.java d5095bc pom.xml 7a79aed Diff: https://reviews.apache.org/r/12559/diff/ Testing ------- Passes 'mvn clean verify' (also with hadoop_2.0.0 profile). Passed real job on the cluster with both hive-io and hcatalog. Thanks, Maja Kabiljo --===============4512529663991836346==--