giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-721) Don't call progress on each edge/vertex loaded
Date Fri, 19 Jul 2013 01:21:47 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713228#comment-13713228
] 

Avery Ching commented on GIRAPH-721:
------------------------------------

+1
Since the main thread periodically calls progress(), this is good to go.
                
> Don't call progress on each edge/vertex loaded
> ----------------------------------------------
>
>                 Key: GIRAPH-721
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-721
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-721.patch
>
>
> While loading data with edge input, we call context.progress() on each edge. I was experimenting
with where cpu is going during the input with hundreds of billions of edges, and about 10%
of it is just calling progress. We don't need to call progress here at all, since the main
thread which waits on input threads to finish does that for us.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message