giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bingjing Zhang" <jesse...@gmail.com>
Subject Re: Review Request 12174: Add "one-to-all" message sending strategy
Date Mon, 01 Jul 2013 00:16:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12174/
-----------------------------------------------------------

(Updated July 1, 2013, 12:16 a.m.)


Review request for giraph.


Changes
-------

Refactor sendMessageCache and add sendMessageToAllCache.


Bugs: GIRAPH-701
    https://issues.apache.org/jira/browse/GIRAPH-701


Repository: giraph-git


Description
-------

Add "one-to-all" message sending strategy.
Now when sendMessageToAllEdges is invoked, Giraph may apply "one-to-all" message sending strategy.
To enable it, use conf.enableOneToAllMsgSending() 


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/comm/SendCache.java 92d0926 
  giraph-core/src/main/java/org/apache/giraph/comm/SendMessageCache.java 40023c2 
  giraph-core/src/main/java/org/apache/giraph/comm/SendMessageToAllCache.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java affc260 
  giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 89fb3e4

  giraph-core/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java
f18af5b 
  giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
d786db5 
  giraph-core/src/main/java/org/apache/giraph/comm/requests/RequestType.java 4129fb8 
  giraph-core/src/main/java/org/apache/giraph/comm/requests/SendWorkerOneToAllMessagesRequest.java
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 2d232a6 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java c65b5f0 
  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 87d5879 
  giraph-core/src/main/java/org/apache/giraph/utils/ByteArrayOneToAllMessages.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/utils/ByteArrayVertexIdData.java 9b3f165 
  giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java c8c09df 
  giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java bc5b5e2 
  giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/GiraphHCatInputFormat.java 2e91cba


Diff: https://reviews.apache.org/r/12174/diff/


Testing
-------

Did
mvn clean verify
mvn clean test


Thanks,

Bingjing Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message