Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 123BC1006B for ; Wed, 12 Jun 2013 03:26:02 +0000 (UTC) Received: (qmail 2013 invoked by uid 500); 12 Jun 2013 03:26:01 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 1960 invoked by uid 500); 12 Jun 2013 03:26:00 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 1952 invoked by uid 99); 12 Jun 2013 03:25:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2013 03:25:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4CBDF1CC9E1; Wed, 12 Jun 2013 03:25:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5303199609494747283==" MIME-Version: 1.0 Subject: Re: Review Request: aggregator at input super step From: "Bingjing Zhang" To: "Avery Ching" , "giraph" , "Bingjing Zhang" Date: Wed, 12 Jun 2013 03:25:50 -0000 Message-ID: <20130612032550.3558.12001@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bingjing Zhang" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/11525/ X-Sender: "Bingjing Zhang" References: <20130605012927.22886.55119@reviews.apache.org> In-Reply-To: <20130605012927.22886.55119@reviews.apache.org> Reply-To: "Bingjing Zhang" --===============5303199609494747283== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11525/ ----------------------------------------------------------- (Updated June 12, 2013, 3:25 a.m.) Review request for giraph. Changes ------- update comments, remove unnecessary functions. Description ------- add aggregator for vertex reader and edge reader at input super step. Changes in code: add "aggregate" interface to VertexReader and EdgeReader initialize "aggregator" in "readInputSplit" in "VertexInputSplitsCallable" = and "EdgeInputSplitsCallable" initialize master aggregator before data loading in "coordinateSuperStep" i= n "BspServiceMaster" seperate master aggregator initialization and its computation for Super Ste= p 0 (originally they are mixed in one method "runMasterCompute") perpare aggregator in "setup" in "BspServiceWorker" before data loading Test: Add SimpleVertexReader and SimpleEdgeReader to AggregatorsTestComputation = for genreating input data. Also add "aggregate" call in "getCurrentVertex" and "getCurrentEdge". Register persistent aggregator with name "INPUT_VERTEX_PERSISTENT_AGG" and = "INPUT_EDGE_PERSISTENT_AGG"in AggregatorsTestMasterCompute.initialize Assert if aggregated values can be retrived in AggregatorsTestMasterCompute= .compute when "superstep >=3D 0" This addresses bug GIRAPH-673. https://issues.apache.org/jira/browse/GIRAPH-673 Diffs (updated) ----- giraph-core/src/main/java/org/apache/giraph/io/EdgeReader.java 363a5e6 = giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 9695169 = giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeReader= .java aae7a72 = giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexRead= er.java 54adfec = giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java = bd48116 = giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java = 8b5e39a = giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallabl= e.java 78cdd8e = giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCalla= ble.java 977e100 = giraph-examples/src/main/java/org/apache/giraph/examples/AggregatorsTestC= omputation.java db527f2 = giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregato= rsHandling.java 6d22800 = Diff: https://reviews.apache.org/r/11525/diff/ Testing ------- Unit Test of persistent aggregator at input super step in modified "Aggrega= torsTestComputation" is done. "mvn clean verify" was done on giraph-core "mvn clean verfiy" was done on giraph-example rechecked "indent" problem. Hopefully they are all solved Thanks, Bingjing Zhang --===============5303199609494747283==--