Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2692BCECF for ; Tue, 11 Jun 2013 17:29:33 +0000 (UTC) Received: (qmail 95894 invoked by uid 500); 11 Jun 2013 17:29:33 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 95796 invoked by uid 500); 11 Jun 2013 17:29:32 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 95780 invoked by uid 99); 11 Jun 2013 17:29:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 17:29:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D994E1CA71D; Tue, 11 Jun 2013 17:29:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7113148935315530290==" MIME-Version: 1.0 Subject: Re: Review Request: review updates From: "Nitay Joffe" To: "Avery Ching" , "giraph" , "Nitay Joffe" , "Alessandro Presta" Date: Tue, 11 Jun 2013 17:29:25 -0000 Message-ID: <20130611172925.3558.76575@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nitay Joffe" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/11709/ X-Sender: "Nitay Joffe" References: <20130611172847.3558.47873@reviews.apache.org> In-Reply-To: <20130611172847.3558.47873@reviews.apache.org> Reply-To: "Nitay Joffe" --===============7113148935315530290== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/ ----------------------------------------------------------- (Updated June 11, 2013, 5:29 p.m.) Review request for giraph. Changes ------- Avery and Alessandro's comments Description ------- See JIRA This addresses bug GIRAPH-683. https://issues.apache.org/jira/browse/GIRAPH-683 Diffs (updated) ----- CHANGELOG fe0c8fdc6d73520318cd531755a6af25b0ba7b84 = giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/Ac= cumuloEdgeInputFormat.java 108ae61d5e57ba293a414028e1cb8b8c685b150c = giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 = giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.jav= a 23c614b1112dd455a97b6ee7d32188dc5a5fd574 = giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.j= ava bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 = giraph-core/src/main/java/org/apache/giraph/comm/SendMutationsCache.java = 9348e61cd83985d920d3ed825d0fbdb3f3ab9fff = giraph-core/src/main/java/org/apache/giraph/comm/SendPartitionCache.java = 68ce0955d8088ed87a6599fd5cd144cd7e470e6c = giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProce= ssor.java 731d0eee0123ea9b5cecc47cff18d6be174f3e47 = giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientR= equestProcessor.java 06965ca488aceb593a249a7c88bd49d660080c20 = giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java = d00f7e908605d8753eb129d0173cf1980034dcc9 = giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02= b5ba85b7fce23d6494c847e986a3d391 = giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c= 16ec8849641847d53aea8c90dcc0a3fcd646e45 = giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d= 120b18bdbbf13c8426ec49f8619d273684620 = giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70= d904660f14370c2e5c98cc59b6a48ea18135 = giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-= CREATION = giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa2= 1a281525858208b1ee81be1eafa5ddcb22a0f = giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb= 14e4962ec9326c3d58b9de33ad83eb23621 = giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java= 58a3f0179d17cd04f2e69789a6e3838cb22d75eb = giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0= f59cecfdf580609c9d6373c0878c90cede430 = giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CRE= ATION = giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphCo= nfiguration.java aa5249875de551a341a4baac894c68553cbd6e63 = giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e= 9dc4d1696b11251a8e8cac870f6bbf72230 = giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc= 164756de8a422a8f23f01809200b4d569cbf = giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a58= 3d98820ef946258d2e2a14fc279583b5c5c = giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 420bf9353= 871540594309ee9b4c129ae91ea7680 = giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.jav= a 139fc7afb75aac92488e4aec7da3ff8bfbcd540c = giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158d= f3ded55360af179e08194e14bc43949c77 = giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java= PRE-CREATION = giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.jav= a PRE-CREATION = giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFacto= ry.java PRE-CREATION = giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertex.java PRE-= CREATION = giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 9= 9b28df74232504f2b2a16639473e367f53dd15f = giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java 1241ae757b2= 9cb7bec80fd3bb3d2bab1ac9c21bd = giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java 6f= 54dc701a5f5dc4589140dfb4a6d0dc5f128dca = giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 9695169b= 5ccf8325987e42de90e7cd3011c0b901 = giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java 70e= 721ec8e4a120a094206e5b857b9bb75eb7acd = giraph-core/src/main/java/org/apache/giraph/io/formats/GraphvizOutputForm= at.java PRE-CREATION = giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloa= tDoubleVertexInputFormat.java 112860c12d203b734093973c3b5d9dd6db39b14a = giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertex= InputFormat.java 91a19e6484631e4334b6c3843ba7aedfec169276 = giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertex= InputFormat.java 1d31f4fb7a688ce314be5608f88726daa9152833 = giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFor= mat.java debdcccaf96cf105b5c0b3a73515f82860913178 = giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrap= per.java ca35c517666910e613431a3641f48f8df223f8b4 = giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValida= tor.java de17157dcbeb123fc43184742a59ed1116070dd6 = giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFacto= ry.java PRE-CREATION = giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-C= REATION = giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-= CREATION = giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java = a12ef58eec93aa4e801955efcd42f0e5c899275e = giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartition= Store.java dadce0f14fe4ecac1dd35c35adf593a63e9583d9 = giraph-core/src/main/java/org/apache/giraph/partition/Partition.java aebd= 34344b10cb3752c74c27f62bf3cfa5d3d565 = giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java= d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 = giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f0= 68c4478706e96a726c5caa2f8fda4563 = giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputForm= at.java 6ca488cb42efec02b49f1ec9b4d22ec0b40bca42 = giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.ja= va b4920e1a015eda3ea5d5c381d5b0155f38f1891a = giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96= 352bbfc0901e44ffe25bbe2f280a216c797131 = giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java 6e46a76b= 656543c97a6b0c5eaad848633bd48bb6 = giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java = 8b5e39a021adc733ff6fc1ef62d6aea6abd61256 = giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py P= RE-CREATION = giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java= d0a6c46114b5d2b42a5fcdba93e293d404e4257f = giraph-core/src/test/java/org/apache/giraph/io/TestAdjacencyListTextVerte= xOutputFormat.java fdfb5e91dc692283a67f7fcaf309e8387f75a36d = giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjace= ncyListVertexInputFormat.java c67a1c44eed7b35a3c872d2032bc4e5ae77e7ef7 = giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjace= ncyListVertexInputFormat.java 80340528326d9b37a380d9a761115b28b879ce2d = giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CR= EATION = giraph-core/src/test/java/org/apache/giraph/partition/TestGiraphTransferR= egulator.java 8a1e9edaea53476d50dd90d70afc80c76d7f090a = giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores= .java 45542b9083f8821ee664487791a7b6a50c115c8e = giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java d2109283= 74b21e42bac960c2d191386df42c119e = giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.jav= a PRE-CREATION = giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PR= E-CREATION = giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDouble= TextInputFormat.java f56b4f6a4c3f26e521829b5da4718ed8bc4e7b64 = giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTe= xtInputFormat.java bfb5f40bd2e7b8da321b5b818e377fea16fccecd = giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongD= oubleDoubleTextInputFormat.java 5023a4e2ca80cf6fe0afe83598c11b00308fc630 = giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankCo= mputation.java d053bb3ceb0c77a3a6dbe46ffa330e9d5f8d035c = giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepC= omputation.java c3fd215b29a445b540a39b99f39cd7eaee195c91 = giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 28edbba= 58a0513a2fe0b051e02e723dfd283de20 = giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedCompone= ntsComputationTestInMemory.java b94f8dcbd961d24f341cff252512c3a102b37ddb = giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPa= thsComputationTest.java 93a3248f7fd5a94a84c8daf7c277ca954c859071 = giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleCl= osingComputationTest.java 73516a473ffd500500aeba083889ca3e5b7c3f03 = giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdg= eInputFormat.java 1af46d1d6f9e2add4eb25ecdf1e5b351b5bf9132 = giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdg= eOutputFormat.java a04d3864334158781b051e29fa8d02e3eba2b630 = giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVerte= xInputFormat.java 53c7eed811e326980f8adf4a34ba41a4152b5416 = giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 34= 0b4618ce8fdd4ec2303866b2ded632535e40a4 = pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b = Diff: https://reviews.apache.org/r/11709/diff/ Testing ------- Thanks, Nitay Joffe --===============7113148935315530290==--